Repository navigation
Backport: Fix various issues holding up CI (22) - #33562
Merged
Merged
Conversation
- Disables the remote operator tests, which will have to be fixed later. - Fixes the action expired error which occurs when accessing regular registration page with Organizations enabled. - Fixes a race condition in the test suite causing sporadic failures. Closes keycloak#33064 Signed-off-by: Stefan Guilhen <sguilhen@redhat.com> Signed-off-by: rmartinc <rmartinc@redhat.com> Signed-off-by: Jon Koops <jonkoops@gmail.com> Co-authored-by: rmartinc <rmartinc@redhat.com> Co-authored-by: Jon Koops <jonkoops@gmail.com>
mposolda
approved these changes
Oct 4, 2024
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.ui.account2.SessionTest#welcomeScreenAsyncLogoutTestKeycloak CI - Account Console IT (firefox) org.keycloak.testsuite.forms.BrowserFlowTest#testAlternativeNonInteractiveExecutorInSubflowKeycloak CI - Forms IT (firefox) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #33064
PR: #33086
Commit: 42cde0c
Target branch: https://github.com/keycloak/keycloak/tree/release/22.0
Fix for the saml hang in ArtifactBindingWithResolutionServiceTest. In upstream the PR fixed several things. Just the needed commit is backported.