8000 Action expired error occurs when accessing regular registration page … by vramik · Pull Request #33065 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Action expired error occurs when accessing regular registration page … - #33065

Closed
vramik wants to merge 1 commit into
keycloak:mainfrom
vramik:33064-null-tokenString
Closed

Action expired error occurs when accessing regular registration page …#33065
vramik wants to merge 1 commit into
keycloak:mainfrom
vramik:33064-null-tokenString

Conversation

@vramik
@vramik vramik commented Sep 18, 2024
Copy link
Copy Markdown
Contributor

…with Organizations enabled

Closes #33064

@vramik
Action expired error occurs when accessing regular registration page …
855d690 
…with Organizations enabled

Closes keycloak#33064

Signed-off-by: vramik <vramik@redhat.com>
@vramik
vramik requested a review from a team as a code owner September 18, 2024 14:53
@vramik
vramik requested a review from sguilhen September 18, 2024 14:53
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Sep 18, 2024
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Sep 18, 2024
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.webauthn.registration.PubKeySignRegisterTest#publicKeySignaturesNonExisting

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmas
8000
ter%2Fapp%2Fauth&state=5e8e74ab-33ca-41ed-8e5c-d5d5bee64c05&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

org.keycloak.testsuite.webauthn.registration.passwordless.PwdLessResidentKeyRegTest#residentKeyRequiredCorrect

Keycloak CI - WebAuthn IT (chrome)

java.lang.AssertionError: Expected RegisterPage but was Sign in to test (https://localhost:8543/auth/realms/test/protocol/openid-connect/auth?response_type=code&client_id=test-app&redirect_uri=https%3A%2F%2Flocalhost%3A8543%2Fauth%2Frealms%2Fmaster%2Fapp%2Fauth&state=873e0c1b-8221-4fb6-9d04-400293746bf8&scope=openid)
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.keycloak.testsuite.pages.AbstractPage.assertCurrent(AbstractPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
...

Report flaky test

@ahus1
ahus1 commented Sep 18, 2024 •
edited
Loading
Copy link
Copy Markdown
Member

@jonkoops - can you please have a look at https://github.com/keycloak/keycloak/actions/runs/10924714425/job/30330678806?pr=33065 -- I restarted it once, and I a second re-run is running now. Not sure if that one will complete. Thanks!

@jonkoops
jonkoops commented Sep 18, 2024
Copy link
Copy Markdown
Contributor

calling @keycloak/ui

@sguilhen
sguilhen commented Sep 18, 2024 •
edited
Loading
Copy link
Copy Markdown
Contributor

@jonkoops @ahus1 Problem here is that with orgs enabled, the default browser flow has now a different structure in new realms created. I could not find a way to make the test work with the new flow, so for this test I've tried switching to master realm before checking the browser flow structure. The flows are not changed in master, only in new realms - looks promising, see #33086

@sguilhen
sguilhen commented Sep 18, 2024
Copy link
Copy Markdown
Contributor

Can't make the other PR get a green CI - I'm facing operator failures all the time in pretty much every PR I open. That one is not an option yet unless someone can re-run the failing tests

@sguilhen
sguilhen commented Sep 19, 2024
Copy link
Copy Markdown
Contributor

Closing in favor of #33086

@sguilhen sguilhen closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
@sguilhen sguilhen sguilhen approved these changes
@jonkoops jonkoops jonkoops approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Action expired error occurs when accessing regular registration page with Organizations enabled

4 participants

@vramik @ahus1 @jonkoops @sguilhen
0