Repository navigation
Use note to detect the IDP verify email action is already done - #33304
Merged
Merged
Conversation
Closes keycloak#31563 Signed-off-by: rmartinc <rmartinc@redhat.com>
jonkoops
approved these changes
Sep 26, 2024
This was referenced Sep 26, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #31563
If the IdP email verification for linking an account is done in another browser, the verification is detected as already done and login cannot continue. The current implementation detects it as already verified because the session is transient (the verification is done in another browser) and has no action in it. The PR uses the VERIFY_ACCOUNT_IDP_USERNAME note instead of the action to check if this session (when not transient) or the other initiating session (when transient) has already being marked by the note as executed.