Repository navigation
fix: detecting when we can set the serviceName - #40894
Merged
Merged
Conversation
vmuzikar
reviewed
Jul 3, 2025
Contributor
There was a problem hiding this comment.
This will work for now. But still, I'm wondering if we shouldn't have a fully fledged upgrade test, ideally using OLM to see if it complains about some breaking changes in the CRDs.
Contributor
Author
There was a problem hiding this comment.
There's an existing issue on the olm upgrades.
vmuzikar
previously approved these changes
Jul 3, 2025
Contributor
There was a problem hiding this comment.
Over all, LGTM. The comments around tests are not blocking.
Contributor
Author
|
Had to update the timeout - the test is run both as local_apiserver, and remote, so the remote test needs more time. |
closes: keycloak#40890 Signed-off-by: Steve Hawkins <shawkins@redhat.com>
vmuzikar
approved these changes
Jul 4, 2025
Contributor
|
@shawkins Can you please create the backport? |
shawkins
added a commit
to shawkins/keycloak
that referenced
this pull request
Jul 5, 2025
closes: keycloak#40890 Signed-off-by: Steve Hawkins <shawkins@redhat.com> (cherry picked from commit 9198380)
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #40890