Repository navigation
Fix NPE when accessing group concurrently - #40940
Merged
pedroigor merged 1 commit intoJul 8, 2025
Merged
Conversation
vramik
force-pushed
the
40368-NPE-concurrent-groups-deletion
branch
from
July 7, 2025 16:48
03b3496 to
8f3c849
Compare
Closes keycloak#40368 Signed-off-by: vramik <vramik@redhat.com>
vramik
force-pushed
the
40368-NPE-concurrent-groups-deletion
branch
from
July 7, 2025 16:54
8f3c849 to
4def149
Compare
vramik
marked this pull request as ready for review
July 7, 2025 18:55
pedroigor
approved these changes
Jul 8, 2025
mfeuerstein
reviewed
Apr 10, 2026
There was a problem hiding this comment.
PR Review — approved
Reviewed 4 files. 0 high-severity issues found. Verdict: approved.
services/src/main/java/org/keycloak/utils/GroupUtils.java (low)
- Reviewed services/src/main/java/org/keycloak/utils/GroupUtils.java — looks good
model/infinispan/src/main/java/org/keycloak/models/cache/infinispan/entities/CachedGroup.java (low)
- Reviewed model/infinispan/src/main/java/org/keycloak/models/cache/infinispan/entities/CachedGroup.java — looks good
tests/base/src/test/java/org/keycloak/tests/admin/group/GroupTest.java (low)
- Reviewed tests/base/src/test/java/org/keycloak/tests/admin/group/GroupTest.java — looks good
model/infinispan/src/main/java/org/keycloak/models/cache/infinispan/GroupAdapter.java (low)
- Reviewed model/infinispan/src/main/java/org/keycloak/models/cache/infinispan/GroupAdapter.java — looks good
Member
|
@mfeuerstein - adding automated, AI generated reviews on an already closed PR is spamming this repository. If you want to help, you can join the discussion for example by sharing prompts or an agents skill file with us that you think is good to review PRs in this repository. |
zach-source
reviewed
Jul 31, 2026
There was a problem hiding this comment.
Null return relocates NPE to callers; regression test lacks thread join — see inline.
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #40368