8000 Synchronize Maven surefire plugin with Quarkus by mabartos · Pull Request #41489 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Synchronize Maven surefire plugin with Quarkus - #41489

Merged
mabartos merged 2 commits into
keycloak:mainfrom
mabartos:KC-41488
Jul 30, 2025
Merged

Synchronize Maven surefire plugin with Quarkus#41489
mabartos merged 2 commits into
keycloak:mainfrom
mabartos:KC-41488

Conversation

@mabartos
@mabartos mabartos commented Jul 29, 2025 •
edited
Loading
Copy link
Copy Markdown
Member

The version of the surefire was changed automatically by executing script:

./set-quarkus-version.sh 3.24.5

@Pepo48 @shawkins Could you please check it as you made changes to the script?

I expect that we might add some version overrides from the Quarkus parent pom.xml in the future

@mabartos
mabartos requested a review from Pepo48 July 29, 2025 09:37
@mabartos
mabartos requested review from a team as code owners July 29, 2025 09:37
mabartos
mabartos commented Jul 29, 2025
View reviewed changes
Comment thread quarkus/set-quarkus-version.sh Resolved
@mabartos mabartos self-assigned this Jul 29, 2025
@mabartos
mabartos commented Jul 29, 2025
Copy link
Copy Markdown
Member Author

Failures in documentation caused by: #41491

Pepo48
Pepo48 reviewed Jul 29, 2025
View reviewed changes
Comment thread quarkus/set-quarkus-version.sh Resolved
mabartos and others added 2 commits July 29, 2025 12:24
@mabartos @Pepo48
Synchronize Maven surefire plugin with Quarkus
ac081b1 
Closes keycloak#41488

Co-authored-by: Peter Zaoral <pepo48@gmail.com>
Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
ExternalLinks are broken in documentation
f8c7908 
Closes keycloak#41491

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
mabartos commented Jul 29, 2025 •
edited
Loading
Copy link
Copy Markdown
Member Author

@Pepo48 We'd need to unfortunatelly add even the fix for Documentation. Otherwise the CI will not pass.

They blocking each other as when we provide only the surefire upgrade, the documentation CI fail. If we provide only the fix for external links, we don't fully verify it's working in CI. Thus, I suggest to include them both to this PR.

@ahus1 Could you please check the second commit for fixing the ExternalLinks test? Thanks

@mabartos
mabartos requested a review from ahus1 July 29, 2025 11:27
@mabartos
mabartos commented Jul 29, 2025
Copy link
Copy Markdown
Member Author

Docs tests passed:
https://github.com/keycloak/keycloak/actions/runs/16593799982/job/46935564791?pr=41489

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running org.keycloak.documentation.test.ExternalLinksTest
SLF4J: No SLF4J providers were found.
SLF4J: Defaulting to no-operation (NOP) logger implementation
SLF4J: See https://www.slf4j.org/codes.html#noProviders for further details.
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 35.91 s -- in org.keycloak.documentation.test.ExternalLinksTest
[INFO] 
[INFO] Results:
[INFO] 
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0
[INFO]

@mabartos mabartos mentioned this pull request Jul 29, 2025
Merged
@mabartos
mabartos commented Jul 30, 2025
Copy link
Copy Markdown
Member Author

@Pepo48 @shawkins @ahus1 Ready for review. Thanks

ahus1
ahus1 approved these changes Jul 30, 2025
View reviewed changes
@ahus1 ahus1 left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8000

I'm ok with the changes to the documentation.

@mabartos
mabartos merged commit 57cb321 into keycloak:main Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahus1 ahus1 ahus1 approved these changes
@Pepo48 Pepo48 Pepo48 approved these changes

Assignees

@mabartos mabartos

Labels

team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ExternalLinks are broken in documentation Synchronize Maven surefire plugin with Quarkus

3 participants

@mabartos @ahus1 @Pepo48
0