Repository navigation
Allow and control sending UTF-8 emails in the default email sender impl #41715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
7d9585b
Allow and control sending UTF-8 emails in the default email sender impl
rmartinc 89885ca
Fix pattern for message resource file
ahus1 fc76d1c
Remove reference to Jakarta mail as it is an internal implementation …
ahus1 77d032e
Use character entity for the regex to avoid issues with variables
rmartinc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,71 @@ | ||
| /* | ||
| * Copyright 2025 Red Hat, Inc. and/or its affiliates | ||
| * and other contributors as indicated by the @author tags. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.keycloak.utils; | ||
|
|
||
| import java.net.IDN; | ||
| import java.util.Map; | ||
| import org.keycloak.email.EmailException; | ||
| import org.keycloak.email.EmailSenderProvider; | ||
| import org.keycloak.models.KeycloakSession; | ||
|
|
||
| /** | ||
| * SMTP utility methods. | ||
| * | ||
| * @author rmartinc | ||
| */ | ||
| public class SMTPUtil { | ||
|
|
||
| private SMTPUtil() { | ||
| // static helper class | ||
| } | ||
|
|
||
| /** | ||
| * Validates the configuration using the email sender provider. | ||
| * | ||
| * @param session The keycloak session to use | ||
| * @param config The configuration to validate | ||
| * @throws EmailException If some error is found in the configuration | ||
| */ | ||
| public static void checkSMTPConfiguration(KeycloakSession session, Map<String, String> config) throws EmailException { | ||
| if (config == null || config.isEmpty()) { | ||
| return; | ||
| } | ||
|
|
||
| final EmailSenderProvider sender = session.getProvider(EmailSenderProvider.class); | ||
| sender.validate(config); | ||
| } | ||
|
|
||
| /** | ||
| * Converts an email address to its ASCII representation using punycode | ||
| * (IDN.toASCII) for the domain part. The local part is not modified. | ||
| * | ||
| * @param email The email to convert | ||
| * @return The converted email or null (if IDN.toASCII throws an exception) | ||
| */ | ||
| public static String convertIDNEmailAddress(String email) { | ||
| final int idx = email == null ? -1 : email.indexOf('@'); | ||
| if (idx < 0) { | ||
| return email; | ||
| } | ||
| try { | ||
| return email.substring(0, idx) + '@' + IDN.toASCII(email.substring(idx + 1)); | ||
| } catch (IllegalArgumentException e) { | ||
| return null; | ||
| } | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably a valid Javadoc would be useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!