8000 [OID4VCI] Restore support for pre-auth tx_code (blocked) by tdiesler · Pull Request #46952 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

[OID4VCI] Restore support for pre-auth tx_code (blocked) - #46952

Closed
tdiesler wants to merge 4 commits into
keycloak:mainfrom
tdiesler:ghi46261-p6
Closed

[OID4VCI] Restore support for pre-auth tx_code (blocked)#46952
tdiesler wants to merge 4 commits into
keycloak:mainfrom
tdiesler:ghi46261-p6

Conversation

@tdiesler
@tdiesler tdiesler commented Mar 6, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

closes #47652

depends on

  1. [OID4VCI] Add a client policy to allow preauth offers (blocked) #46897

To reduce friction, we removed tx_code in favor support for authorization_code grant. Now that we have the latter, it'd be useful to restore tx_code for pre-authorized_code grants

@tdiesler
tdiesler requested review from a team as code owners March 6, 2026 19:22
@tdiesler
tdiesler force-pushed the ghi46261-p6 branch 3 times, most recently from 69c987d to c67aca9 Compare March 9, 2026 11:02
@keycloak-github-bot
keycloak-github-bot Bot commented Mar 9, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.federation.ldap.LDAPGroupMapperTest#test01_ldapOnlyGroupMappings

Keycloak CI - Base IT (5)

java.lang.AssertionError: expected:<4> but was:<1>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:647)
	at org.junit.Assert.assertEquals(Assert.java:633)
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Mar 9, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@tdiesler
tdiesler force-pushed the ghi46261-p6 branch 15 times, most recently from afda453 to 17da8e8 Compare March 13, 2026 13:52
@tdiesler tdiesler changed the title OID4VCI] Restore support for pre-auth tx_code - Part6 OID4VCI] Restore support for pre-auth tx_code Mar 13, 2026
@VinodAnandan
VinodAnandan commented Mar 16, 2026
Copy link
Copy Markdown
Contributor

@tdiesler Would it be possible to update the PR description so it more accurately reflects the changes in this PR?

Also, I wanted to get your thoughts on whether it would be better to handle the tx_code policy support (headless mode vs. UI-only mode) within this PR, or if it would make more sense to include it in the policy PR instead?

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Mar 27, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Mar 27, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.broker.KcOidcBrokerTest#loginWithExistingUserWithBruteForceEnabled

Keycloak CI - Java Distribution IT (windows-latest - temurin - 17)

org.openqa.selenium.TimeoutException: 
Expected condition failed: waiting for value to contain (ignoring case) "sign in to". Current value: "AUTH_RESPONSE" (tried for 5 second(s) with 500 milliseconds interval)
Build info: version: '4.28.1', revision: '73f5ad48a2'
System info: os.name: 'Windows Server 2025', os.arch: 'amd64', os.version: '10.0', java.version: '17.0.18'
Driver info: org.jboss.arquillian.drone.webdriver.htmlunit.DroneHtmlUnitDriver_ByGraphene
...

Report flaky test

@tdiesler tdiesler closed this Mar 28, 2026
@tdiesler
tdiesler deleted the ghi46261-p6 branch March 28, 2026 12:54
@tdiesler tdiesler mentioned this pull request Mar 31, 2026
Closed
@tdiesler
tdiesler restored the ghi46261-p6 branch March 31, 2026 20:12
@tdiesler tdiesler reopened this Mar 31, 2026
@tdiesler tdiesler changed the title OID4VCI] Restore support for pre-auth tx_code [OID4VCI] Restore support for pre-auth tx_code Mar 31, 2026
@tdiesler
tdiesler force-pushed the ghi46261-p6 branch 9 times, most recently from fd1e815 to b9ce9f5 Compare April 2, 2026 06:13
@tdiesler tdiesler changed the title [OID4VCI] Restore support for pre-auth tx_code [OID4VCI] Restore support for pre-auth tx_code (blocked) Apr 8, 2026
@tdiesler
tdiesler force-pushed the ghi46261-p6 branch 2 times, most recently from 70e2842 to 63e3d60 Compare April 9, 2026 05:57
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Apr 9, 2026
Closed
@tdiesler
tdiesler force-pushed the ghi46261-p6 branch 2 times, most recently from b64ba8d to 7c6ab1c Compare April 10, 2026 04:33
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Apr 24, 2026
Closed
tdiesler added 4 commits April 28, 2026 08:51
@tdiesler
[OID4VCI] Add a client policy to require a credential offer
6c04844 
Signed-off-by: Thomas Diesler <tdiesler@proton.me>
@tdiesler
-- add switch control in Admin UI
363597d 
Signed-off-by: Thomas Diesler <tdiesler@proton.me>
@tdiesler
[OID4VCI] Add a client policy to allow preauth offers
d293cdf 
Signed-off-by: Thomas Diesler <tdiesler@proton.me>
@tdiesler
[OID4VCI] Restore support for pre-auth tx_code
e89af87 
Signed-off-by: Thomas Diesler <tdiesler@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mposolda mposolda mposolda requested changes
Copilot code review Copilot
Copilot will automatically review once the pull request is marked ready for review
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@mposolda mposolda

Labels

flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[OID4VCI] Restore support for pre-auth tx_code

3 participants

@tdiesler @VinodAnandan @mposolda
0