Repository navigation
avoid SRCFG01008 warning for log-console-output=default in Quarkus dev mode - #47746
Closed
kowshik-04 wants to merge 1 commit into
Closed
kowshik-04 wants to merge 1 commit into
kowshik-04 wants to merge 1 commit into
Conversation
…us dev mode Extend augmentation detection to include Quarkus dev mode using LaunchMode.DEVELOPMENT, so runtime configuration values are not incorrectly passed through boolean conversion during dev-mode startup. Closes keycloak#47659 Signed-off-by: kowshikmente <kowshikmente@kowshikmentes-MacBook-Pro.local>
Contributor
|
Thank you for you interest in this issue, but after reviewing this and the other pr it seems best to be more general in how we're detecting when augmentation is running. Please see #47748 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47659
The existing logic that suppresses runtime values during augmentation relied on system properties that are not set in Quarkus dev mode.
This change introduces a centralized augmentation detection method and extends it to include Quarkus dev mode via LaunchMode.DEVELOPMENT, so dev mode follows the same behavior as other augmentation paths.
As a result, runtime configuration values are no longer incorrectly passed through boolean conversion during dev-mode startup, preventing the SRCFG01008 warning.
Behavior validated via test coverage.
Note: AI tools were used to assist with code exploration and drafting. All changes were reviewed and verified manually.