8000 fix: consistently resetting the configuration by shawkins · Pull Request #47870 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

fix: consistently resetting the configuration - #47870

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss47869
Apr 9, 2026
Merged

vmuzikar merged 1 commit into
keycloak:mainfrom
shawkins:iss47869

Conversation

@shawkins
@shawkins shawkins commented Apr 8, 2026
Copy link
Copy Markdown
Contributor

closes: #47869

@shawkins
shawkins marked this pull request as ready for review April 8, 2026 19:23
@shawkins
shawkins requested review from a team as code owners April 8, 2026 19:23
closes: keycloak#47869

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
@shawkins
shawkins requested a review from vmuzikar April 9, 2026 13:31

@Override
public void initConfig(AbstractCommand command) {
KeycloakConfigSourceProvider.reload();
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're not calling Configuration.resetConfig() somewhere here, are we?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That call was a workaround for missing it somewhere else when resetting the config. Now that we do it consistently we don't need this one off.

@vmuzikar
vmuzikar merged commit e9b38d0 into keycloak:main Apr 9, 2026
88 checks passed
@stianst stianst mentioned this pull request Jun 1, 2026
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
closes: keycloak#47869

Signed-off-by: Steve Hawkins <shawkins@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configuration reset isn't always complete

3 participants

0