Repository navigation
add validation to description based on the validation annotations #47375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
56a45aa
add validation to description based on the validation annotations
edewit 21640a8
added test and better encapsulation
edewit 2039fc9
Remove applySchemaProperties() from ValidationAnnotationScanner
edewit 2dd694f
change to use class instead of string
edewit 39f88c0
added error when encountering group annotation that isn't in the map
edewit 44f3c81
fixed test and added openapi.yaml from js folder
edewit 546284c
make it spotless
edewit 46f035e
made the scanner more generic and use the validation message
edewit 2a08d9d
use interpolation for the other annotations
edewit 12da2ef
updated more PR reviews
edewit bc80408
more PR review comments
edewit b96a0b2
fixed merge
edewit 0433e99
moved class level validator descriptions
edewit b8c18e2
added field name to annotation, that we can then use in the schema
edewit dfe5976
don't put validations that have an affectedField on the class
edewit 3e6cc2d
jandex default
edewit 4a50426
fixed test
edewit c637b1e
even more PR review comments
edewit 199b2ee
small fix to get more validations in the description
edewit ec3ef97
better handle on parmeterised types
edewit 7ac6531
Update generated spec
vmuzikar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,4 +27,5 @@ | |
|
|
||
| Class<? extends Payload>[] payload() default {}; | ||
|
|
||
| String[] affectedFieldNames(); | ||
| } | ||
<
10000
button
type="button"
class="btn-link color-fg-muted no-underline js-collapse-diff tooltipped tooltipped-se"
aria-label="Collapse expanded lines"
hidden
>
1 change: 1 addition & 0 deletions
1
...pi/src/main/java/org/keycloak/representations/admin/v2/validation/ProtocolUnmodified.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.