8000 Rewrite AssertEvents expectLoginEvent to EventAssertion. by lhanusov · Pull Request #48467 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Rewrite AssertEvents expectLoginEvent to EventAssertion. - #48467

Merged
stianst merged 1 commit into
keycloak:mainfrom
lhanusov:48353
May 4, 2026
Merged

Rewrite AssertEvents expectLoginEvent to EventAssertion.#48467
stianst merged 1 commit into
keycloak:mainfrom
lhanusov:48353

Conversation

@lhanusov
@lhanusov lhanusov commented Apr 24, 2026 •
edited
Loading
Copy link
Copy Markdown
Contributor

Closes #48618

@lhanusov
lhanusov force-pushed the 48353 branch 3 times, most recently from 0c2a20b to c75845b Compare April 24, 2026 15:51
This was referenced Apr 24, 2026
Closed
Closed
Closed
Closed
@lhanusov
lhanusov force-pushed the 48353 branch 2 times, most recently from e2d5410 to 43e1f90 Compare April 27, 2026 13:15
This was referenced Apr 27, 2026
Closed
Closed
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 27, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Apr 27, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.user.UserModelTest#testAddDirtyRemoveFederationUsersInTheSameGroupConcurrent

Keycloak CI - Store Model Tests

org.opentest4j.MultipleFailuresError: 
Multiple Failures (2 failures)
	java.lang.NullPointerException: <no message>
	org.infinispan.commons.IllegalLifecycleStateException: Cache container has been stopped and cannot be reused. Recreate the cache container.
	Suppressed: java.lang.NullPointerException
...

Report flaky test

@lhanusov
lhanusov force-pushed the 48353 branch 2 times, most recently from de6005a to 0715a69 Compare April 27, 2026 15:04
@keycloak-github-bot keycloak-github-bot Bot mentioned this pull request Apr 27, 2026
Closed
keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 27, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-git 8000 hub-bot Bot commented Apr 27, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.model.user.UserModelTest#testAddRemoveUser

Keycloak CI - Store Model Tests

org.opentest4j.MultipleFailuresError: 
Multiple Failures (2 failures)
	java.lang.NullPointerException: Cannot invoke "org.keycloak.models.KeycloakSessionFactory.create()" because "factory" is null
	java.lang.NullPointerException: Null keys are not supported!
	Suppressed: java.lang.NullPointerException: Cannot invoke "org.keycloak.models.KeycloakSessionFactory.create()" because "factory" is null
...

Report flaky test

keycloak-github-bot[bot]
keycloak-github-bot Bot reviewed Apr 27, 2026
View reviewed changes
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
keycloak-github-bot Bot commented Apr 27, 2026
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.authz.PolicyEvaluationTest#

Keycloak CI - Base IT (3)

org.opentest4j.AssertionFailedError: expected: <PERMIT> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
...

org.opentest4j.AssertionFailedError: expected: <PERMIT> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
...

org.opentest4j.AssertionFailedError: expected: <PERMIT> but was: <null>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertEquals.failNotEqual(AssertEquals.java:197)
	at org.junit.jupiter.api.AssertEquals.assertEquals(AssertEquals.java:182)
...

Report flaky test

org.keycloak.testsuite.model.session.OfflineSessionPersistenceTest#testPersistenceMultipleNodesClientSessionAtSameNode

Keycloak CI - Store Model Tests

java.lang.AssertionError: 
threads didn't terminate in time: [main (TIMED_WAITING): locked on java.util.concurrent.FutureTask@7b28bdc3 waiting for 100686 ms blocked for 2 ms
	at java.base@25.0.2/jdk.internal.misc.Unsafe.park(Native Method)
	at java.base@25.0.2/java.util.concurrent.locks.LockSupport.parkNanos(LockSupport.java:271)
	at java.base@25.0.2/java.util.concurrent.FutureTask.awaitDone(FutureTask.java:508)
...

Report flaky test

org.keycloak.testsuite.model.session.UserSessionInitializerTest#testUserSessionPropagationBetweenSites

Keycloak CI - Store Model Tests

java.lang.AssertionError: 
threads didn't terminate in time: [main (RUNNABLE):
	at java.management@25.0.2/sun.management.ThreadImpl.dumpThreads0(Native Method)
	at java.management@25.0.2/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:505)
	at java.management@25.0.2/sun.management.ThreadImpl.dumpAllThreads(ThreadImpl.java:493)
...

Report flaky test

@lhanusov
lhanusov force-pushed the 48353 branch 6 times, most recently from 941f35a to c682da6 Compare April 29, 2026 11:00
This was referenced Apr 29, 2026
Closed
Closed
@lhanusov
lhanusov marked this pull request as ready for review April 29, 2026 12:48
@lhanusov
lhanusov requested review from a team as code owners April 29, 2026 12:48
@lhanusov
lhanusov force-pushed the 48353 branch 2 times, most recently from 30f1321 to e1b6b39 Compare April 29, 2026 13:13
@lhanusov
lhanusov requested review from stianst and vaceksimon April 29, 2026 13:14
@lhanusov
lhanusov force-pushed the 48353 branch 2 times, most recently from a83a0a8 to 8cdfeaf Compare April 30, 2026 07:56
@lhanusov lhanusov self-assigned this Apr 30, 2026
@lhanusov lhanusov added the area/test-framework Test framework — infrastructure, Realm DSL, page objects, migration utils label Apr 30, 2026
@lhanusov
Rewrite AssertEvents expectLoginEvent to EventAssertion.
fbaee3c 
Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
@stianst stianst self-assigned this Apr 30, 2026
@stianst
stianst merged commit 4f47022 into keycloak:main May 4, 2026
84 of 86 checks passed
@stianst stianst mentioned this pull request Jun 1, 2026
Closed
sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
@lhanusov @sashyo
Rewrite AssertEvents expectLoginEvent to EventAssertion. (keycloak#48467
6dd2415 
)

Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stianst stianst stianst approved these changes
@vaceksimon vaceksimon Awaiting requested review from vaceksimon
+1 more reviewer
@keycloak-github-bot keycloak-github-bot[bot] keycloak-github-bot[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@stianst stianst

@lhanusov lhanusov

Labels

area/test-framework Test framework — infrastructure, Realm DSL, page objects, migration utils flaky-test team/cloud-native team/core-clients team/core-iam

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rewrite expectLogin to expectLoginSuccess and expectLoginError

2 participants

@lhanusov @stianst
0