8000 Enhance theme selection by rendering custom names in dropdown selectors. by azc9673 · Pull Request #48484 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Enhance theme selection by rendering custom names in dropdown selectors. - #48484

Open
azc9673 wants to merge 1 commit into
keycloak:mainfrom
azc9673:display-custom-theme-names
Open

azc9673 wants to merge 1 commit into
keycloak:mainfrom
azc9673:display-custom-theme-names

Conversation

@azc9673
@azc9673 azc9673 commented Apr 26, 2026 •
Copy link
Copy Markdown
Contributor

Summary

This PR enhances quick-theme export so custom themes can be imported and displayed more cleanly in Keycloak. The main user-facing feature is to allow the user's inputted theme name to be displayed on theme selection dropdowns.

Changes included:

  • generate theme archives with a sanitized dynamic theme id instead of always using quick-theme
  • store an optional renderedName in META-INF/keycloak-themes.json
  • persist theme descriptions in messages_en.properties for login, account, and admin themes
  • expose renderedName through server info
  • show rendered names in admin theme selectors and client login theme selection while still using the canonical theme id internally

This allows admins to see their originally inputted custom theme names rather than a default quick-theme in theme selectors.

Closes #47866

@azc9673
azc9673 force-pushed the display-custom-theme-names branch from 9a3f87b to de7a8dd Compare May 3, 2026 20:45
@azc9673
azc9673 marked this pull request as ready for review May 3, 2026 20:47
@azc9673
azc9673 requested review from a team as code owners May 3, 2026 20:47
These changes allow quick-theme exports to use and preserve custom names, and theme selectors to display rendered custom names.

Closes keycloak#47866

Signed-off-by: azc9673 <azc9673@nyu.edu>
@azc9673
azc9673 force-pushed the display-custom-theme-names branch from de7a8dd to ffea3ef Compare May 3, 2026 21:10
@azc9673 azc9673 changed the title Enhance quick-theme JAR generation with rendered names and descriptions Enhance theme selection by rendering custom names in dropdown selectors. May 3, 2026
@azc9673
azc9673 commented May 3, 2026
Copy link
Copy Markdown
Contributor Author
8000

Quick question to maintainers: this PR also includes changes to a test file tests/base/src/test/java/org/keycloak/tests/admin/ServerInfoTest.java that just includes an assertion test for the new field that was created to hold custom names. Should it be kept with the PR, or should I remove it? Thanks!

@edewit edewit left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 from a UI point of view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display custom theme names on theme selection

3 participants

0