8000 ExternalLinksTest is broken by mabartos · Pull Request #48789 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

ExternalLinksTest is broken - #48789

Closed
mabartos wants to merge 1 commit into
keycloak:mainfrom
mabartos:external-links-docs
Closed

ExternalLinksTest is broken#48789
mabartos wants to merge 1 commit into
keycloak:mainfrom
mabartos:external-links-docs

Conversation

@mabartos
@mabartos mabartos commented May 7, 2026
Copy link
Copy Markdown
Member

@mabartos
mabartos force-pushed the external-links-docs branch from 53a671d to 044c240 Compare May 7, 2026 11:39
@mabartos
ExternalLinksTest is unstable
1e38c98 
Closes keycloak#48788

Signed-off-by: Martin Bartoš <mabartos@redhat.com>
@mabartos
mabartos force-pushed the external-links-docs branch from 044c240 to 1e38c98 Compare May 7, 2026 11:44
@mabartos mabartos changed the title Allow retries for Docs External links test for 4xx responses ExternalLinksTest is unstable May 7, 2026
@vramik
vramik commented May 7, 2026
Copy link
Copy Markdown
Contributor

@mabartos the problem might be that the https://www.oasis-open.org/standard/saml/ blocks automated requests with 403, while accessing it via browser works.

FYI I've added the link into ignored-links in https://github.com/keycloak/keycloak/pull/48702/changes#diff-0d702c6f58d0c32eb70d624afbc8f48dffb92b7407f16153b056f0d3cee169d6R43

@mabartos
mabartos commented May 7, 2026 •
edited
Loading
Copy link
Copy Markdown
Member Author

@vramik Yes, that's what I thought, and described it in the issue. Thanks for the info.

I'll check if it needs to be backported, and if yes, it seems that it should not be part of your PR. I'll let you know.

@mabartos
mabartos commented May 7, 2026
Copy link
Copy Markdown
Member Author

@vramik It was added as part of this:

Which is part of the 26.6.0

So, I'd suggest to have it separated and proceed with this PR and backport it to 26.6.0.

Does it work to you?

@mabartos
mabartos marked this pull request as ready for review May 7, 2026 12:01
@mabartos
mabartos requested a review from a team as a code owner May 7, 2026 12:01
@mabartos mabartos changed the title ExternalLinksTest is unstable ExternalLinksTest is broken May 7, 2026
@vramik
vramik commented May 7, 2026
Copy link
Copy Markdown
Contributor

@mabartos it works, I'll rebase my PR once this one lands, thanks

@mabartos
mabartos commented May 7, 2026
Copy link
Copy Markdown
Member 8000 Author

Ok, fixed already right now 😄

#48682

@mabartos mabartos closed this May 7, 2026
@rmartinc
rmartinc commented May 7, 2026
Copy link
Copy Markdown
Contributor

Thanks @mabartos, this is already managed by #48681. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ExternalLinksTest is broken

3 participants

@mabartos @vramik @rmartinc
0