8000 Allow using the parameter in the consent text for dynamic scopes by rmartinc · Pull Request #48843 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

Allow using the parameter in the consent text for dynamic scopes - #48843

Merged
pedroigor merged 1 commit into
keycloak:mainfrom
rmartinc:issue-9915
May 14, 2026
Merged

pedroigor merged 1 commit into
keycloak:mainfrom
rmartinc:issue-9915

Conversation

@rmartinc
@rmartinc rmartinc commented May 8, 2026
Copy link
Copy Markdown
Contributor

Closes #9915

Just using the advancedMsg to allow parametrization of the dynamic client scope consent text. This allows the admin to use a text using placeholder {0} to add the parameter passed to the text. The admin can use a direct text or a key in different languages.

edewit
edewit previously approved these changes May 11, 2026
@mabartos
mabartos self-requested a review May 11, 2026 10:14
@mabartos mabartos left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmartinc Overall, it looks good. I've just added a few nitpicks/suggestions.

mabartos
mabartos previously approved these changes May 12, 2026
@mabartos mabartos left a comment
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmartinc Thanks for the responses on these nitpicks. LGTM

@rmartinc
rmartinc dismissed stale reviews from mabartos and edewit via 2506279 May 12, 2026 15:56
@rmartinc
rmartinc force-pushed the issue-9915 branch 2 times, most recently from 2506279 to e01018d Compare May 12, 2026 16:00
Closes keycloak#9915

Signed-off-by: rmartinc <rmartinc@redhat.com>
@rmartinc
Copy link
Copy Markdown
Contributor Author

Rebasing to fix the annoying lint error in the admin console. Let's see now.

@pedroigor
pedroigor merged commit 4cca6f7 into keycloak:main May 14, 2026
87 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the consent screen text for dynamic scopes customizable with a reference to the dynamic scope parameter

4 participants

0