Repository navigation
Conversation
Closes keycloak#48101 Signed-off-by: Giuseppe Graziano <g.graziano94@gmail.com>
lhanusov
suggested changes
May 18, 2026
Comment on lines
+24
to
+34
| @Override | ||
| public String getRef(InjectClient annotation) { | ||
| String ref = StringUtil.convertEmptyToNull(SupplierHelpers.getAnnotationField(annotation, AnnotationFields.REF)); | ||
| if (ref != null) { | ||
| return ref; | ||
| } | ||
| // Fallback to attachTo | ||
| String attachTo = annotation.attachTo(); | ||
| return attachTo.isEmpty() ? null : attachTo; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Please, remove it, after a team discussion, this is not the way we want support current test-framework lifecycle.
Suggested change
| @Override | |
| public String getRef(InjectClient annotation) { | |
| String ref = StringUtil.convertEmptyToNull(SupplierHelpers.getAnnotationField(annotation, AnnotationFields.REF)); | |
| if (ref != null) { | |
| return ref; | |
| } | |
| // Fallback to attachTo | |
| String attachTo = annotation.attachTo(); | |
| return attachTo.isEmpty() ? null : attachTo; | |
| } |
stianst
requested changes
May 20, 2026
Contributor
There was a problem hiding this comment.
I'm not convinced about the attachTo in the first place we added for clients; feels wrong from a test-framework perspective.
Could you elaborate on why this is needed and show some tests where you're using this? My thinking is that it would be better to actually create a realm managed user, or using some of the methods from ManagedRealm.
Contributor
|
this issue won't be implemented, rather we've decided to remove attachTo from client as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48101