8000 [OID4VCI] Conformance with OpenID HAIP Profile by tdiesler · Pull Request #49563 · keycloak/keycloak · GitHub
[go: up one dir, main page]

Skip to content

[OID4VCI] Conformance with OpenID HAIP Profile - #49563

Closed
tdiesler wants to merge 5 commits into
keycloak:mainfrom
tdiesler:ghi47149-haip
Closed

tdiesler wants to merge 5 commits into
keycloak:mainfrom
tdiesler:ghi47149-haip

Conversation

@tdiesler
@tdiesler tdiesler commented Jun 2, 2026
Copy link
Copy Markdown
Contributor

closes #47149

@tdiesler
tdiesler force-pushed the ghi47149-haip branch 4 times, most recently from eff445c to c63b225 Compare June 2, 2026 09:12
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginWithoutForcePasswordChangePolicy

Keycloak CI - Store IT (mariadb)

java.lang.IllegalArgumentException: No enum constant org.keycloak.testsuite.pages.AppPage.RequestType.
	at java.base/java.lang.Enum.valueOf(Enum.java:293)
	at org.keycloak.testsuite.pages.AppPage$RequestType.valueOf(AppPage.java:58)
	at org.keycloak.testsuite.pages.AppPage.getRequestType(AppPage.java:47)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:104)
...

Report flaky test

@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.forms.LoginTest#loginExpiredCodeWithExplicitRemoveExpired

Keycloak CI - Store IT (mariadb)

org.opentest4j.AssertionFailedError: Expected LoginPage but was  (https://localhost:8543/auth/realms/test/login-actions/authenticate?session_code=E6jXHhDQNYkec6Q4iD1LwbxRoYXphzubdE50pLRsmnY&execution=4e277561-d72f-411b-b3cb-641a227054f6&client_id=test-app&tab_id=KOuY071EMJs&client_data=eyJydSI6Imh0dHBzOi8vbG9jYWxob3N0Ojg1NDMvYXV0aC9yZWFsbXMvbWFzdGVyL2FwcC9hdXRoIiwicnQiOiJjb2RlIn0) ==> expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
...

Report flaky test

@tdiesler
tdiesler force-pushed the ghi47149-haip branch 6 times, most recently from e5bae47 to 4c2ef97 Compare June 5, 2026 08:46
@keycloak-github-bot keycloak-github-bot Bot left a comment
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unreported flaky test detected, please review

@keycloak-github-bot
Copy link
Copy Markdown

Unreported flaky test detected

If the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR.

org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#employeeSigPostNoIdpKeyTestKeyIdAsKeyNameInKeyInfo

Keycloak CI - Adapter IT Strict Cookies

org.opentest4j.AssertionFailedError: expected: <true> but was: <false>
	at org.junit.jupiter.api.AssertionFailureBuilder.build(AssertionFailureBuilder.java:151)
	at org.junit.jupiter.api.AssertionFailureBuilder.buildAndThrow(AssertionFailureBuilder.java:132)
	at org.junit.jupiter.api.AssertTrue.failNotTrue(AssertTrue.java:63)
	at org.junit.jupiter.api.AssertTrue.assertTrue(AssertTrue.java:36)
...

Report flaky test

tdiesler added 5 commits June 24, 2026 10:57
…equest-uri-prior-to-auth-completion-succeeds

closes keycloak#48072

Signed-off-by: Thomas Diesler <tdiesler@proton.me>

* Stop consuming/removing PAR request objects when first parsing request_uri at the authorization endpoint
* Defer PAR removal until authentication/authorization completes.
* Persist the request_uri in the authentication session so it can be consumed later.
* Add a new Details.REQUEST_URI constant for reuse as an auth-note key.
closes keycloak#48071

Signed-off-by: Thomas Diesler <tdiesler@proton.me>

* Add cnf_type to the cnf (confirmation) structure in tokens and set it for DPoP / ABCA bindings.
* Bind refresh tokens to the ABCA client instance public key thumbprint when client attestation is used, and add server-side verification on refresh.
* Add an HAIP issuer conformance test that validates access token (DPoP) and refresh token (ABCA) binding behavior.
Signed-off-by: Thomas Diesler <tdiesler@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OID4VCI] Conformance with OpenID HAIP Profile

2 participants

0