8000 Correct themes readme by andymunro · Pull Request #49609 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Correct themes readme - #49609

Merged
vmuzikar merged 1 commit into
keycloak:mainfrom
andymunro:49608
Jun 4, 2026
Merged

Correct themes readme#49609
vmuzikar merged 1 commit into
keycloak:mainfrom
andymunro:49608

Conversation

@andymunro
@andymunro andymunro commented Jun 2, 2026
Copy link
Copy Markdown
Contributor

Closes #49608

@andymunro
andymunro requested review from a team as code owners June 2, 2026 15:05
Closed
@andymunro
Correct themes readme
a634712 
Closes keycloak#49608

Signed-off-by: AndyMunro <amunro@redhat.com>
michalvavrik
michalvavrik approved these changes Jun 4, 2026
View reviewed changes
@michalvavrik michalvavrik left a comment •
edited
Loading
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So we are recommending docs/guides/ui-customization/index.adoc, https://www.keycloak.org/guides#ui-customization , that sounds about right to me. Thanks!

@vmuzikar
vmuzikar commented Jun 4, 2026
Copy link
Copy Markdown
Contributor

Adding a link to this guide is out of scope, because it would only apply in upstream

I think a link would be ok. We're talking about a README file, and as such it's not pointing the users but devs and is part of the source code, not docs.

@andymunro
andymunro commented Jun 4, 2026
Copy link
Copy Markdown
Contributor Author

Thanks, @vmuzikar. Currently we have a link to the upstream Server Developer Guide in the ReadMe. I have replaced it with the name of UI Customization Guide. If we include a link to the upstream guide, they will see information that does not apply downstream. If so, we would need a separate readme for downstream.

@vmuzikar
vmuzikar commented Jun 4, 2026
Copy link
Copy Markdown
Contributor

We're talking about a README file, and as such it's not pointing the users but devs and is part of the source code, not docs.

I take this back. The README is part of the distribution. Sorry for the noise.

@vmuzikar
vmuzikar merged commit 5e753f1 into keycloak:main Jun 4, 2026
90 checks passed
8000
@andymunro
andymunro commented Jun 4, 2026
Copy link
Copy Markdown
Contributor Author

Thanks, @vmuzikar

sashyo pushed a commit to tide-foundation/keycloak-IGA that referenced this pull request Jul 20, 2026
@andymunro @sashyo
Correct themes readme (keycloak#49609)
12cc64d 
Closes keycloak#49608

Signed-off-by: AndyMunro <amunro@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vmuzikar vmuzikar vmuzikar approved these changes
+1 more reviewer
@michalvavrik michalvavrik michalvavrik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

flaky-test team/cloud-native

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Correct themes README

4 participants

@andymunro @vmuzikar @michalvavrik @stianst
0