Repository navigation
Move AuthorizationCodeTest to the new testsuite - #49772
Merged
mposolda merged 1 commit intoJun 12, 2026
Merged
Conversation
lhanusov
force-pushed
the
test-migration/authorizationcodetest
branch
from
June 8, 2026 10:44
92a65b3 to
3aa317c
Compare
lhanusov
force-pushed
the
test-migration/authorizationcodetest
branch
from
June 8, 2026 11:40
3aa317c to
a5a8a82
Compare
mposolda
previously approved these changes
Jun 9, 2026
Contributor
There was a problem hiding this comment.
@lhanusov Thanks!
I would slightly prefer to use constants like OAuth2Constants.CODE , OAuth2Constants.ERROR , OAuth2Constants.RESPONSE instead of hardcoded strings like "code", "error" etc. But that is rather a minor thing, which can be improved in case there are more change requests for this PR. But I don't consider it blocker for the PR, so approving.
lhanusov
force-pushed
the
test-migration/authorizationcodetest
branch
from
June 9, 2026 08:41
a5a8a82 to
1735aa9
Compare
stianst
reviewed
Jun 9, 2026
Contributor
There was a problem hiding this comment.
Maybe we should introduce isSuccess and isError in AuthorizationEndpointResponse?
The implementation would basically just be:
boolean isSuccess() {
return isRedirected() && code != null;
}
boolean isError() {
return isRedirected() && error != null;
}
That'd be a bit cleaner than having to do assertNotNull. As it's just
Assertions.assertTrue(oauth.parseLoginRepsonse().isSuccess();
lhanusov
force-pushed
the
test-migration/authorizationcodetest
branch
2 times, most recently
from
June 9, 2026 12:42
fa52800 to
bca23a3
Compare
mposolda
previously approved these changes
Jun 9, 2026
Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
lhanusov
force-pushed
the
test-migration/authorizationcodetest
branch
from
June 11, 2026 06:47
bca23a3 to
309e608
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.saml.SamlClientTest#testLoginWithOIDCClientKeycloak CI - Java Distribution IT (windows-latest - temurin - 17) org.keycloak.testsuite.saml.SamlClientTest#testLoginWithOIDCClientKeycloak CI - Java Distribution IT (windows-latest - temurin - 21) org.keycloak.testsuite.saml.SamlClientTest#testLoginWithOIDCClientKeycloak CI - Java Distribution IT (ubuntu-latest - temurin - 21) org.keycloak.testsuite.saml.SamlClientTest#testLoginWithOIDCClientKeycloak CI - Java Distribution IT (ubuntu-latest - temurin - 17) |
mposolda
approved these changes
Jun 12, 2026
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
Closes keycloak#48201 Signed-off-by: Lukas Hanusovsky <lhanusov@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48201