8000 fix: updating the auto logic if the pod cannot be found by shawkins · Pull Request #49030 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

fix: updating the auto logic if the pod cannot be found #49030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shawkins merged 1 commit into from
May 19, 2026
Merged

fix: updating the auto logic if the pod cannot be found #49030

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 8 additions & 15 deletions operator/src/main/java/org/keycloak/operator/update/impl/AutoUpdateLogic.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@
package org.keycloak.operator.update.impl;

import java.util.Collection;
import java.util.List;
import java.util.Objects;
import java.util.Optional;
import java.util.stream.Stream;
Expand Down Expand Up @@ -68,10 +69,9 @@ Optional<UpdateControl<Keycloak>> onUpdate() {

var pod = findPodForJob(context.getClient(), existingJob.get());
if (pod.isEmpty()) {
// TODO some cases the pod is removed. Do we start over or use recreate update?
Log.warn("Pod for Update Job not found.");
decideRecreateUpdate("The Pod running update-compatibility command not found.");
return Optional.empty();
Log.warn("Pod for completed Update Job not found, will restart the Job");
context.getClient().resource(existingJob.get()).lockResourceVersion().delete();
return Optional.of(UpdateControl.noUpdate());
}

checkUpdateType(pod.get());
Expand All @@ -81,17 +81,10 @@ Optional<UpdateControl<Keycloak>> onUpdate() {
private boolean isJobRunning(Job job) {
var status = job.getStatus();
Log.debugf("Update Job Status:%n%s", CRDUtils.toJsonNode(status, context).toPrettyString());
var completed = Optional.ofNullable(status).stream()
.mapMultiToInt((jobStatus, downstream) -> {
if (jobStatus.getSucceeded() != null) {
downstream.accept(jobStatus.getSucceeded());
}
if (jobStatus.getFailed() != null) {
downstream.accept(jobStatus.getFailed());
}
}).sum();
// we only have a single pod, so completed will be zero if running or 1 if finished.
return completed == 0;
return Optional.ofNullable(status)
.map(s -> s.getConditions().stream().noneMatch(
jc -> "True".equals(jc.getStatus()) && List.of("Complete", "Failed").contains(jc.getType())))
.orElse(true);
}

private void checkUpdateType(Pod pod) {
Expand Down
Loading
0