Repository navigation
Format Terms and Conditions accepted timestamp - #49031
Merged
Merged
Conversation
palasht75
force-pushed
the
fix-terms-accepted-date-display
branch
from
May 22, 2026 00:35
512a976 to
e29f962
Compare
palasht75
marked this pull request as ready for review
May 22, 2026 02:50
edewit
requested changes
May 22, 2026
Comment on lines
+284
to
+289
| <TextInput | ||
| id={TERMS_AND_CONDITIONS_ATTRIBUTE} | ||
| data-testid={TERMS_AND_CONDITIONS_ATTRIBUTE} | ||
| value={formatDate(termsAndConditionsAcceptedDate)} | ||
| readOnly | ||
| /> |
Contributor
There was a problem hiding this comment.
When it's always readonly it's better to have this as plain text as the user might wonder what would be needed / what would allow to edit this value
Comment on lines
+464
to
+465
| const milliseconds = timestamp > 9999999999 ? timestamp : timestamp * 1000; | ||
| const date = new Date(milliseconds); |
Contributor
There was a problem hiding this comment.
this is not needed right it's always in millis
Closes keycloak#44591 Signed-off-by: Palash Thakur <palash@LAPTOP-8OJ5UPT8.localdomain>
palasht75
force-pushed
the
fix-terms-accepted-date-display
branch
from
May 25, 2026 02:14
e29f962 to
43d1661
Compare
edewit
approved these changes
May 28, 2026
Closed
sashyo
pushed a commit
to tide-foundation/keycloak-IGA
that referenced
this pull request
Jul 20, 2026
Closes keycloak#44591 Signed-off-by: Palash Thakur <palash@LAPTOP-8OJ5UPT8.localdomain> Co-authored-by: Palash Thakur <palash@LAPTOP-8OJ5UPT8.localdomain>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Formats the Terms and Conditions accepted timestamp in the Admin UI user details screen.
Previously, the value was displayed as a raw millisecond timestamp. This change displays it as a readable date/time value while preserving the stored value and backend behavior.
Closes #44591.
Testing
Using Java 21 and the repository-required frontend tooling:
cd js && corepack pnpm --fail-if-no-match --filter @keycloak/keycloak-admin-ui lint- PASScd js && corepack pnpm --fail-if-no-match --filter @keycloak/keycloak-admin-ui test- PASScd js && corepack pnpm --fail-if-no-match --filter @keycloak/keycloak-admin-ui build- PASS./mvnw spotless:check- PASScd js && corepack pnpm --fail-if-no-match --filter @keycloak/keycloak-admin-ui test:integration -- --project=chromium test/users/main.spec.ts- PASScd js && corepack pnpm --fail-if-no-match --filter @keycloak/keycloak-admin-ui test:integration -- --project=chromium test/realm-settings/userprofile.spec.ts- PASScd js && corepack pnpm --fail-if-no-match --filter @keycloak/keycloak-admin-ui test:integration -- --project=chromium --grep "Required actions" test/autentication/flows.spec.ts- PASSPost-rebase check after rebasing onto latest
upstream/main:cd js && corepack pnpm --fail-if-no-match --filter @keycloak/keycloak-admin-ui test- PASScd js && corepack pnpm --fail-if-no-match --filter @keycloak/keycloak-admin-ui test:integration -- --project=chromium test/users/main.spec.ts- PASSRisk
The change is scoped to Admin UI display formatting for the Terms and Conditions accepted timestamp.
The stored value, API behavior, Terms and Conditions required action flow, and unrelated user attributes are unchanged.
AI assistance
I used an AI coding agent to assist with preparing this change. I reviewed the implementation and tests and am responsible for the result.