Repository navigation
[OID4VCI-HAIP] Pass oid4vci-1_0-issuer-happy-flow - #49221
Merged
Merged
Conversation
tdiesler
force-pushed
the
ghi47316
branch
3 times, most recently
from
May 21, 2026 18:41
468df62 to
c221c91
Compare
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#salesPostSigEmailTestKeycloak CI - Adapter IT Strict Cookies org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#testReloginWithInvalidAuthSessionCookieKeycloak CI - Adapter IT Strict Cookies |
mposolda
previously approved these changes
May 22, 2026
tdiesler
force-pushed
the
ghi47316
branch
4 times, most recently
from
May 24, 2026 08:45
018cb18 to
7a9b991
Compare
mposolda
reviewed
May 25, 2026
Contributor
There was a problem hiding this comment.
@tdiesler Can you please rebase on top of latest main? As in the meantime, I've merged other PR by Dominik, which was also important and was in the queue for a longer time:#48869 .
There will be likely some small update needed in the HAIPIssuerConformanceTest in the configuration of trusted keys (instead of option on the client-authenticator, there is a need to create IDP and reference this IDP from the client configuration. You can check similar changes for the OIDCAttestationBasedClientAuthenticationTest in that PR)
tdiesler
force-pushed
the
ghi47316
branch
2 times, most recently
from
June 1, 2026 07:47
85f701d to
b6542f9
Compare
closes keycloak#47316 -- add x5c certificates to header except for trust anchor -- add DPoP to token and credential request -- add DPoP support to basic wallet -- explicit usage of nonce in credential proof Signed-off-by: Thomas Diesler <tdiesler@proton.me>
Contributor
mposolda
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #47316
-- add x5c certificates to header except for trust anchor
-- add DPoP to token and credential request
-- add DPoP support to basic wallet
-- explicit usage of nonce in credential proof