Repository navigation
Migrated ExportImportTest and associated files - #49338
Conversation
4004986 to
208fba7
Compare
|
Please rebase and resolve conflicts |
There was a problem hiding this comment.
Thanks a lot @msdaly200! Just a few suggestions.
There was a problem hiding this comment.
Thanks @msdaly200! LGTM! @vaceksimon please check the PR when you have time.
|
Hi @vaceksimon could you review? Thanks! |
| // The test should verify that import works when filename doesn't match realm name | ||
| // Revisit when the server-side functionality is fixed |
There was a problem hiding this comment.
Correct me if I'm wrong, but the commit I previously linked suggests that this test actually verifies that import doesn't work when the filename doesn't match the realm name. Which means this is exactly as intended and there is no need to fix the server-side functionality.
There was a problem hiding this comment.
I used github to remove the lines and add a nother one to make the test pass (it seems another test is setting the realm and we need to set it to null).
Signed-off-by: Marie Daly <marie.daly1@ibm.com>
Signed-off-by: Marie Daly <marie.daly1@ibm.com>
Signed-off-by: Marie Daly <marie.daly1@ibm.com>
Signed-off-by: Marie Daly <marie.daly1@ibm.com>
Signed-off-by: Marie Daly <marie.daly1@ibm.com>
Signed-off-by: Marie Daly <marie.daly1@ibm.com>
Signed-off-by: Marie Daly <marie.daly1@ibm.com>
Signed-off-by: Marie Daly <marie.daly1@ibm.com>
Signed-off-by: Marie Daly <marie.daly1@ibm.com>
Signed-off-by: Marie Daly <marie.daly1@ibm.com>
There was a problem hiding this comment.
I think those lines are wrong...
…tImportTest.java Signed-off-by: Ricardo Martin <rmartinc@redhat.com>
…tImportTest.java Signed-off-by: Ricardo Martin <rmartinc@redhat.com>
|
@msdaly200 I have applied the changes, let's see the tests... |
Migrated ExportImportTest and associated files
Closes #48152