Repository navigation
Change TokenManager.isValidScope to always consider dynamic scopes - #49399
Merged
Merged
Conversation
Closes keycloak#49388 Signed-off-by: rmartinc <rmartinc@redhat.com>
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.webauthn.registration.UserVerificationRegisterTest#requiredWrong |
mabartos
reviewed
May 28, 2026
Closes keycloak#49388 Signed-off-by: rmartinc <rmartinc@redhat.com>
mabartos
approved these changes
May 28, 2026
Contributor
Author
|
@vaceksimon I have added you as reviewer, just to take a quick look to the ciba provider. Thanks! |
vaceksimon
approved these changes
May 29, 2026
pedroigor
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #49388
Checking dynamic scopes I detected that they were not working with CIBA. The reason is the
TokenManager.isValidScopeis not considering them. This PR changes this to always consider dynamic scopes if enabled. I have revised all calls to the method. Besides I have added the provider for CIBA in the test-framework following the same idea other https resources are integrated. The test uses the CIBA ping to test the two endpoints, I suppose with this the CIBA test classes can also be migrated to the new test-suite.