Repository navigation
Conversation
jimmychakkalakal
force-pushed
the
review/impersonation_test_review_48193
branch
from
June 26, 2026 16:14
ade10d7 to
8cd2584
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR performs a focused cleanup and correctness pass over ImpersonationTest, improving test reliability and readability in Keycloak’s admin impersonation integration tests.
Changes:
- Fixes test method names/typos and standardizes assertions using Hamcrest
assertThat. - Improves resource lifecycle handling by registering created users/clients for cleanup via
ManagedRealm.cleanup(). - Refactors duplicated cookie extraction logic into a helper and makes the impersonation admin endpoint realm dynamic.
jimmychakkalakal
force-pushed
the
review/impersonation_test_review_48193
branch
from
June 26, 2026 16:24
2df4d31 to
1e03b80
Compare
jimmychakkalakal
force-pushed
the
review/impersonation_test_review_48193
branch
from
June 26, 2026 16:38
1e03b80 to
e733b88
Compare
Closes keycloak#48193 Signed-off-by: Jimmy Chakkalakal <jimmy.chakkalakal@ibm.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: jimmychakkalakal <47317106+jimmychakkalakal@users.noreply.github.com> Signed-off-by: Jimmy Chakkalakal <jimmy.chakkalakal@ibm.com>
mposolda
force-pushed
the
review/impersonation_test_review_48193
branch
from
June 29, 2026 08:41
e733b88 to
bff5dfa
Compare
mposolda
approved these changes
Jun 29, 2026
Contributor
There was a problem hiding this comment.
@jimmychakkalakal Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48193