Repository navigation
Add validation for blocked session note names in UserSessionNoteMapper #53559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mposolda
merged 5 commits into
keycloak:main
from
jimmychakkalakal:cve/53545-Fixes-an-issue-where-UserSessionNoteMapper
Nov 5, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9b3e8fb
fix: block broker credential notes in session note mappers
jimmychakkalakal 727f561
fix: block broker credential notes in session note mappers
jimmychakkalakal 189e01a
Worked on reviewer's comments
jimmychakkalakal 1f54378
fix: include validation-generated mapper config in registration respo…
jimmychakkalakal cdefcf5
Worked to reviews and copilots comments
jimmychakkalakal File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compil
8000
ed differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
server-spi-private/src/main/java/org/keycloak/models/utils/ProtocolMapperValidationUtil.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
| /* | ||
| * Copyright 2016 Red Hat, Inc. and/or its affiliates | ||
| * and other contributors as indicated by the @author tags. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.keycloak.models.utils; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| import org.keycloak.models.KeycloakSession; | ||
| import org.keycloak.models.ProtocolMapperContainerModel; | ||
| import org.keycloak.models.ProtocolMapperModel; | ||
| import org.keycloak.models.RealmModel; | ||
| import org.keycloak.protocol.ProtocolMapper; | ||
| import org.keycloak.protocol.ProtocolMapperConfigException; | ||
|
|
||
| /** | ||
| * Validates the protocol mappers of a container on the paths that write a whole container at | ||
| * once, such as a client scope created inline or a realm import, which do not go through the per-mapper admin | ||
| * endpoint and so never reach {@link ProtocolMapper#validateConfig}. | ||
| */ | ||
| public class ProtocolMapperValidationUtil { | ||
|
|
||
| public static final String INVALID_CONFIG_MESSAGE = "Invalid protocol mapper configuration"; | ||
|
|
||
| private ProtocolMapperValidationUtil() { | ||
| // utility class | ||
| } | ||
|
|
||
| public static void validateProtocolMappers(KeycloakSession session, RealmModel realm, ProtocolMapperContainerModel container) throws ProtocolMapperConfigException { | ||
| for (ProtocolMapperModel model : container.getProtocolMappersStream().toList()) { | ||
| validateProtocolMapper(session, realm, container, model); | ||
| } | ||
| } | ||
|
|
||
| public static void validateProtocolMapper(KeycloakSession session, RealmModel realm, ProtocolMapperContainerModel container, | ||
| ProtocolMapperModel model) throws ProtocolMapperConfigException { | ||
| ProtocolMapper mapper = (ProtocolMapper) session.getKeycloakSessionFactory() | ||
| .getProviderFactory(ProtocolMapper.class, model.getProtocolMapper()); | ||
| // An import must not fail just because a third-party mapper provider is absent. | ||
| if (mapper == null) { | ||
| return; | ||
| } | ||
|
|
||
| // A mapper may carry no configuration at all, and RepresentationToModel preserves that as null. Validators | ||
| // read the configuration without expecting that, so normalize it and let the mapper report its own error | ||
| // instead of throwing a NullPointerException, which the admin endpoints would report as a 500. | ||
| if (model.getConfig() == null) { | ||
| model.setConfig(new HashMap<>()); | ||
| } | ||
|
|
||
| Map<String, String> originalConfig = new HashMap<>(model.getConfig()); | ||
| mapper.validateConfig(session, realm, container, model); | ||
| // Validators can initialize configuration, for example the pairwise subject mapper's salt. | ||
| // Models read from the container are detached, so these changes must be saved explicitly. | ||
| if (!originalConfig.equals(model.getConfig())) { | ||
| container.updateProtocolMapper(model); | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.