Repository navigation
Fix tooltips in Security defense tab in admin console - #53585
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The tooltip regression needs automated coverage in the existing Security Defenses tests.
Review effort: Balanced
Findings: 1
What changed in this PR
Restores tooltip behavior for Security Defenses help text.
Changes:
- Wraps translated help content in
HelpItem. - Preserves external documentation links inside tooltips.
| File | Description |
|---|---|
HelpLinkTextInput.tsx |
Restores help icons and popovers for security-header fields. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Closes keycloak#53142 Signed-off-by: Martin Bartoš <mabartos@redhat.com>
edewit
approved these changes
Oct 6, 2026
Awambeng
pushed a commit
to adorsys/keycloak-oid4vc
that referenced
this pull request
Oct 6, 2026
Closes keycloak#53142 Signed-off-by: Martin Bartoš <mabartos@redhat.com>
edewit
pushed a commit
that referenced
this pull request
Oct 7, 2026
PadzerButch
pushed a commit
to PadzerButch/-50764_test_migration_keycloak
that referenced
this pull request
Oct 22, 2026
Closes keycloak#53142 Signed-off-by: Martin Bartoš <mabartos@redhat.com>
PadzerButch
pushed a commit
to PadzerButch/-50764_test_migration_keycloak
that referenced
this pull request
Oct 23, 2026
Closes keycloak#53142 Signed-off-by: Martin Bartoš <mabartos@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FormLabelrendered<Trans>help content inline. Wrapping it explicitly inHelpItemrestores the tooltips