Repository navigation
Check if provider implements OnUserCache for the user model - #54411
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues were identified for the change guarding user-cache callbacks with an interface check.
No open issues 🎉
What changed in this PR
This PR makes user caching safer for custom UserProvider implementations by checking whether the delegate implements OnUserCache before invoking its callback.
Changes:
- Replaces an unchecked cast with an
instanceofpattern check, avoiding aClassCastExceptionfor providers withoutOnUserCache. - Preserves the callback for providers that implement the interface.
| File | Description |
|---|---|
model/infinispan/src/main/java/org/keycloak/models/cache/infinispan/UserCacheSession.java |
Guards the cache callback with an interface check. |
Review effort: Balanced
Signed-off-by: Dmitry Repchevsky <redmitry@list.ru>
1 of 2 tasks
ahus1
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54410
This is a safety check before casting that fix potential problems with custom UserProvider implementations.