Repository navigation
Updating OIDCAdvancedRequestParamsTest to the new test framework - #54718
Open
PadzerButch wants to merge 1 commit into
Open
PadzerButch wants to merge 1 commit into
PadzerButch wants to merge 1 commit into
Conversation
PadzerButch
force-pushed
the
OIDCAdvancedRequestParamsTest_Branch
branch
from
November 5, 2026 17:30
1b870e7 to
d975ab6
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Two migrated tests miss their intended checks: the client-ID mismatch case fails early with “Client not found,” and the no-request-URI case leaves the previous allowlist intact.
2 open issues
What changed in this PR
Migrates OIDCAdvancedRequestParamsTest from Arquillian to Keycloak’s new test framework, addressing #54602.
Changes:
- Replaces legacy setup with injected resources and a per-method realm fixture.
- Moves request-object serving and signing to HTTP-server and JWKS helpers.
- Ports advanced OIDC parameter, claims, signature, and encryption tests and removes the legacy class.
| File | Description |
|---|---|
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/oidc/OIDCAdvancedRequestParamsTest.java |
Removes the legacy Arquillian test class. |
tests/base/src/test/java/org/keycloak/tests/oidc/OIDCAdvancedRequestParamsTest.java |
Adds the migrated tests, realm configuration, and request-object helpers. |
Review effort: Balanced
PadzerButch
force-pushed
the
OIDCAdvancedRequestParamsTest_Branch
branch
2 times, most recently
from
November 10, 2026 12:56
46cc4b3 to
4797867
Compare
PadzerButch
marked this pull request as ready for review
November 10, 2026 12:56
PadzerButch
force-pushed
the
OIDCAdvancedRequestParamsTest_Branch
branch
from
November 10, 2026 16:27
4797867 to
63c7b26
Compare
Closes keycloak#54602 Signed-off-by: Paddy Buckley <paddy.buckley@ibm.com>
PadzerButch
force-pushed
the
OIDCAdvancedRequestParamsTest_Branch
branch
from
November 10, 2026 18:12
63c7b26 to
fdf90a5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54602