Repository navigation
Conversation
Signed-off-by: Erkka Tahvanainen <erkka.tahvanainen@confidently.fi>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The organization-name option is missing from the Admin Console configuration, and enabling it alone with the default String claim type discards names and emits only organization aliases.
2 open issues
What changed in this PR
This PR extends the OIDC organization membership mapper to optionally include organization names in token claims.
Changes:
- Adds an
addOrganizationNameoption and conditional name mapping. - Adds English Admin Console label and help text for the option.
| File | Description |
|---|---|
| services/src/main/java/org/keycloak/organization/protocol/mappers/oidc/OrganizationMembershipMapper.java | Adds configuration and claim mapping for organization names. |
| js/apps/admin-ui/maven-resources/theme/keycloak.v2/admin/messages/messages_en.properties | Adds the option’s English label and help text. |
Review effort: Balanced
Signed-off-by: Erkka Tahvanainen <erkka.tahvanainen@confidently.fi>
Signed-off-by: Erkka Tahvanainen <erkka.tahvanainen@confidently.fi>
Comment on lines
+205
to
+206
| if (isAddOrganizationName(model)) { | ||
| claims.put("name", o.getName()); |
Signed-off-by: Erkka Tahvanainen <erkka.tahvanainen@confidently.fi>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr provides possibility to include organization name in organization claim.