Repository navigation
Updating OIDCBackwardsCompatibilityTest to the new test framework - #54987
Open
PadzerButch wants to merge 2 commits into
Open
PadzerButch wants to merge 2 commits into
PadzerButch wants to merge 2 commits into
Conversation
Closes keycloak#54602 Signed-off-by: Paddy Buckley <paddy.buckley@ibm.com>
…ng the migrate-test skill Closes keycloak#54986 Signed-off-by: Paddy Buckley <paddy.buckley@ibm.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are identified for the OIDC test-framework migration.
No open issues 🎉
What changed in this PR
Migrates OIDC backwards-compatibility tests to Keycloak’s new test framework for #54986, alongside the advanced request-parameter tests.
Changes:
- Replaces legacy Arquillian/JUnit 4 setup with framework injection and JUnit 5.
- Uses method-scoped realms to isolate test configuration changes.
- Moves request-object signing and serving to local helpers and framework-provided resources.
| File | Description |
|---|---|
testsuite/integration-arquillian/tests/base/src/test/java/org/keycloak/testsuite/oidc/OIDCAdvancedRequestParamsTest.java |
Removes the legacy advanced request-parameter suite. |
tests/base/src/test/java/org/keycloak/tests/oidc/OIDCBackwardsCompatibilityTest.java |
Migrates session-state and issuer compatibility checks to the new framework. |
tests/base/src/test/java/org/keycloak/tests/oidc/OIDCAdvancedRequestParamsTest.java |
Adds the migrated parameter, claims, signing, and encryption tests. |
Review effort: Balanced
PadzerButch
marked this pull request as ready for review
November 10, 2026 13:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54986