Repository navigation
SCIM: PATCH on a group does not update meta.lastModified - #54990
Open
martin-kanis wants to merge 1 commit into
Open
martin-kanis wants to merge 1 commit into
martin-kanis wants to merge 1 commit into
Conversation
Closes keycloak#54565 Signed-off-by: Martin Kanis <mkanis@ibm.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are recorded for the SCIM PATCH update-hook change.
No open issues 🎉
What changed in this PR
Fixes #54565 by invoking the update hook after SCIM PATCH operations, allowing group changes to advance meta.lastModified and appear in timestamp-based queries.
Changes:
- Calls
onUpdateafter applying patches in the shared resource provider. - Adds a regression test for group membership PATCH, verifying that
lastModifiedadvances,createdstays unchanged, and timestamp filtering returns the group.
| File | Description |
|---|---|
scim/tests/base/src/test/java/org/keycloak/tests/scim/tck/GroupTest.java |
Adds timestamp and filtering regression coverage using a controlled time offset. |
scim/core/src/main/java/org/keycloak/scim/resource/spi/AbstractScimResourceTypeProvider.java |
Invokes the update hook after PATCH operations. |
Review effort: Balanced
Unreported flaky test detectedIf the flaky tests below are affected by the changes, please review and update the changes accordingly. Otherwise, a maintainer should report the flaky tests prior to merging the PR. org.keycloak.testsuite.adapter.servlet.SAMLServletAdapterTest#testPostBadAssertionSignature |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be
2E89
applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54565