8000 Fix generated admin API v2 OpenAPI document locale dependency (#54852) by sanidhya02 · Pull Request #55002 · keycloak/keycloak · GitHub
[go: up one dir, main page]
Skip to content

Fix generated admin API v2 OpenAPI document locale dependency (#54852) #55002

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sanidhya02 wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −1
Open

Fix generated admin API v2 OpenAPI document locale dependency (#54852) #55002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e3bfa13
Fix generated admin API v2 OpenAPI document locale dependency (#54852)
Nov 10, 2026
ede1db2
Merge branch 'main' into issue-54852-openapi-locale
sanidhya02 Nov 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...rvices/src/main/java/org/keycloak/admin/internal/openapi/ValidationAnnotationScanner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import java.util.HashMap;
import java.util.HashSet;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.MissingResourceException;
import java.util.ResourceBundle;
Expand Down Expand Up @@ -81,7 +82,7 @@ public ValidationAnnotationScanner(IndexView indexView) {

private ResourceBundle loadValidationMessages() {
try {
return ResourceBundle.getBundle("org.hibernate.validator.ValidationMessages");
return ResourceBundle.getBundle("org.hibernate.validator.ValidationMessages", Locale.ROOT);
} catch (MissingResourceException e) {
log.warn("Could not load ValidationMessages resource bundle", e);
return null;
Expand Down
14 changes: 14 additions & 0 deletions ...es/src/test/java/org/keycloak/admin/internal/openapi/ValidationAnnotationScannerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -587,4 +587,18 @@ public static class TestWithRepeatableServerManagedFieldUnmodified {
private String protocol;
private Long createdTimestamp;
}

@Test
public void loadValidationMessages_usesRootLocaleEvenWhenDefaultLocaleIsDifferent() {
java.util.Locale originalLocale = java.util.Locale.getDefault();
try {
java.util.Locale.setDefault(java.util.Locale.GERMAN);
ValidationAnnotationScanner germanScanner = new ValidationAnnotationScanner(index);
ClassInfo classInfo = index.getClassByName(TestRepresentation.class);
String description = germanScanner.buildDescription(classInfo, "notBlankField");
assertTrue(description.contains("must not be blank"));
} finally {
java.util.Locale.setDefault(originalLocale);
}
}
}
0