Repository navigation
[fixes #9224] Always show the consent screen when a dynamic scope is requested and show the requested parameter - #9802
Conversation
6b83ed3 to
a2a2854
Compare
a2a2854 to
07d275d
Compare
07d275d to
fe1f1ff
Compare
There was a problem hiding this comment.
I wonder that it may be more user-friendly to display some message like
Send 200 USD
instead of something like:
Sending USD - Dynamic Scope Parameter: 200
The consent screen is displayed to end users, but end-user probably won't know at all what the Dynamic Scope Parameter is?
IMO the ideal experience is, that dynamic client scope send-money will have consentScreenText configured like sendMoneyScopeTxt . Then in messages_en.properties resource bundle will be some message like:
sendMoneyScopeTxt=Send {0} USD
Then in the ftl template, you would use something like:
${advancedMsg(clientScope.consentScreenText, clientScope.dynamicScopeParameter)}
This assumes single parameter, which won't be the case for the more complex RAR structures, but for parameterized scope single parameter is likely ok?
I guess this can require some changes in the AdvancedMessageFormatterMethod utility as it seems it does not yet have support for parameters sent to the messages.
WDYT?
Or would you prefer to go with this one and then improve message in the follow-up PR?
There was a problem hiding this comment.
Yes, this is definitely a great feature to have and as you said, it would be necessary for RAR too.
For this PR though, I thought of the format as the "default" one without any reference to parameters.
I made a small change to the format however, and it should read as:
<scope_name | scope_display_text>:
I'll open a follow up issue to handle the parameterized display text.
Always show the consent screen when a dynamic scope is requested and show the requested parameter Improve the code that handles dynamic scopes consent and add some log traces Add a test to check how we show dynamic scope in the consent screen and added missing template file change Fix merge problem in comment and improve other comments Fix the Dynamic Scope test by assigning it to the client as optional instead of default Change how dynamic scopes are represented in the consent screen and adapt test
fe1f1ff to
c754ce6
Compare
|
Issue referencing this enhancement: #9915 |
Always show the consent screen when a dynamic scope is requested and show the requested parameter
Also make sure we start using the common
AuthorizationDetailsin the code to standardize how we handle Scopes.This is what the consent screen would look like with a dynamic scope with a parameter:
Updated image: