Repository navigation
example how to extend the UI with SPI - #521
Merged
Merged
Conversation
edewit
force-pushed
the
extend-ui-spi
branch
from
December 15, 2023 10:53
b631521 to
6a1130b
Compare
|
nice idea, really like it. I think would be extremly helpful for extensions. Any timeplan in which Keycloak Version it will be available? |
edewit
marked this pull request as ready for review
January 23, 2024 13:00
edewit
force-pushed
the
extend-ui-spi
branch
2 times, most recently
from
January 24, 2024 12:05
f7c8b1a to
d382874
Compare
hmlnarik
suggested changes
Jan 29, 2024
Contributor
There was a problem hiding this comment.
Thank you for the changes. It looks like a most welcome addition worth a quickstart.
Could you add more explanation on the methods in the added java classes - when they are called and what they do, to make them quick to grasp? Also an automated test needs to be added to check the quickstart works correctly.
hmlnarik
suggested changes
Feb 12, 2024
Contributor
There was a problem hiding this comment.
The test fails in the GHA, please fix. Perhaps the .github/scripts needs updating.
Please also see the inline comments
edewit
force-pushed
the
extend-ui-spi
branch
6 times, most recently
from
February 13, 2024 14:16
2438df1 to
5845f67
Compare
hmlnarik
reviewed
Feb 13, 2024
| ``` | ||
|
|
||
| ### Undeploy the quickstart | ||
| Remove sysout listener from your realm in the admin console, delete file providers/event-listener-sysout.jar and restart the server. No newline at end of file |
Contributor
There was a problem hiding this comment.
Please update the provider name
hmlnarik
reviewed
Feb 13, 2024
|  | ||
|
|
||
| ### Integration test of the Quickstart | ||
| Make sure you have a Keycloak server running with an admin user in the master realm or use the provided docker image. |
Contributor
There was a problem hiding this comment.
This does not fit, the provider needs to be installed into the server first.
edewit
force-pushed
the
extend-ui-spi
branch
from
February 13, 2024 14:31
5845f67 to
1a875df
Compare
Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> added explanation on where to find the examples Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> use the parent pom Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> added test Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> Update extension/extend-admin-console-spi/README.md Co-authored-by: Hynek Mlnařík <hmlnarik@users.noreply.github.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> Update extension/extend-admin-console-spi/README.md Co-authored-by: Hynek Mlnařík <hmlnarik@users.noreply.github.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> Update extension/extend-admin-console-spi/src/test/java/org/keycloak/quickstart/ExtendAdminConsoleTest.java Co-authored-by: Hynek Mlnařík <hmlnarik@users.noreply.github.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> Update extension/extend-admin-console-spi/README.md Co-authored-by: Hynek Mlnařík <hmlnarik@users.noreply.github.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> Update extension/extend-admin-console-spi/README.md Co-authored-by: Hynek Mlnařík <hmlnarik@users.noreply.github.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> Update extension/extend-admin-console-spi/README.md Co-authored-by: Hynek Mlnařík <hmlnarik@users.noreply.github.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> Update extension/extend-admin-console-spi/README.md Co-authored-by: Hynek Mlnařík <hmlnarik@users.noreply.github.com> Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> update license header Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> removed deps Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> added providers jas for extend-admin-ui Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com> added save todo test added test for the realm attribute settings page Signed-off-by: Erik Jan de Wit <erikjan.dewit@gmail.com>
edewit
force-pushed
the
extend-ui-spi
branch
from
February 13, 2024 14:34
1a875df to
0ec20ac
Compare
hmlnarik
reviewed
Feb 13, 2024
hmlnarik
reviewed
Feb 13, 2024
hmlnarik
approved these changes
Feb 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an example of how to extend the admin ui by implementing the SPI.
Because this is not merged yet this PR is a draft
see keycloak/keycloak#23772