Repository navigation
pkp/pkp-lib#13708 Remove the unversioned Static Pages migr 8000 ation that moved pages on every upgrade - #6018
Open
mesutk wants to merge 1 commit into
Open
pkp/pkp-lib#13708 Remove the unversioned Static Pages migration that moved pages on every upgrade#6018mesutk wants to merge 1 commit into
mesutk wants to merge 1 commit into
Conversation
…moved pages on every upgrade
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes pkp/pkp-lib#13708
migrateStaticPagesToNavigationMenuItemssits outside any<upgrade>block indbscripts/xml/upgrade.xml, so it runs on every upgrade. Each time, it moves every page out of the Static Pages plugin into a Custom Page navigation menu item and deletes it fromstatic_pages. That was useful once, for the switch to navigation menus in 3.1. Today Static Pages is still bundled and in use, and anything older than 3.3 is already aborted earlier in this file, so the only pages this step still moves are ones people made on purpose.This removes the call. The now unused
Upgrade::migrateStaticPagesToNavigationMenuItems()andNavigationMenuItemDAO::portStaticPage()stay in place here to keep the change small; onmainthey're removed in #6019 and pkp/pkp-lib#13710.Tested by upgrading an OJS journal from 3.5.0-5 to 3.5.0-6 with this line removed: static pages and menus were unchanged and the rest of the upgrade ran as normal. Upgrading OMP 3.5.0-5 to 3.5.0-6 with the line in place moved all 30 of the press's static pages.