Repository navigation
ci: fix nightly lock-suite helper discovery - #889
Open
adityamukho wants to merge 1 commit into
Open
adityamukho wants to merge 1 commit into
adityamukho wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly Docker and NFS lock suites build
pid_ns_helpersuccessfully but look for it in the wrong directory when test executables run undertarget/debug/build/.../out.Set an explicit workflow-wide
CARGO_TARGET_DIRandMINIGRAF_PID_NS_HELPERso both jobs find the built helper independently of the test executable layout. This follows the existing coverage workflow's helper override.Validation:
git diff --checkpasses.Full Docker and mounted-NFS execution requires CI infrastructure and was not run locally.
Fixes #887.
Fixes #888.
Companion
v3PR: #890.