8000 Fix orientation lock updates in the Quran reader by mohamedelghazali · Pull Request #4003 · quran/quran_android · GitHub
[go: up one dir, main page]

Skip to content

Fix orientation lock updates in the Quran reader - #4003

Open
mohamedelghazali wants to merge 4 commits into
quran:mainfrom
mohamedelghazali:fix/3947-orientation-lock
Open

mohamedelghazali wants to merge 4 commits into
quran:mainfrom
mohamedelghazali:fix/3947-orientation-lock

Conversation

@mohamedelghazali
@mohamedelghazali mohamedelghazali commented Nov 4, 2026 •
Copy link
Copy Markdown

Summary

Fixes #3947.

  • Apply the requested orientation before inflating the Quran reader UI, avoiding an initial frame in the previous orientation.
  • Reapply the setting when the reader resumes.
  • React immediately when either orientation preference changes.
  • Reset the activity orientation to SCREEN_ORIENTATION_UNSPECIFIED when the lock is disabled or unsupported, so a previous lock does not remain active.
  • Add unit coverage for portrait, landscape, disabled, and unsupported orientation resolution.

Validation

  • Based on the current upstream main commit; the PR is not based on the stale fork default branch.
  • Reviewed the complete three-file diff.
  • Local build/tests could not be run in this environment because outbound network access is unavailable.
  • GitHub Actions run #4040 is currently action_required with zero jobs, so repository CI has not executed yet and requires maintainer approval.

@mohamedelghazali
mohamedelghazali marked this pull request as ready for review November 4, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug in Lock screen orientation

1 participant

0