You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Do not use the latest Rust version automatically when running automation tasks #225
The combination of picking the last version of Rust with automatically running clippy checks often leads to breakage which is annoying. Oftentimes a user will open a PR to fix an issue and then they'll have to roll in some clippy fixes, or I'll have to land them first before I can merge their PR. We should be sticking to a specific Rust version and only updating when we know that the tests won't fail with it.
So, I just ran into an issue that makes me realize we should take this a step further: We should test with the MSRV that we claim to support in our Cargo.toml file. I just ran into an issue where I was using a feature that was buggy until Rust 1.95, but we claim to support 1.88 in our config file.
Furthermore -- Since Firefox is one of the largest consumers of this crate -- We should probably ensure that our MSRV is aligned with Firefox's -- Which is currently 1.90.
Activity
marti4d commentedon Sep 10, 2026
So, I just ran into an issue that makes me realize we should take this a step further: We should test with the MSRV that we claim to support in our Cargo.toml file. I just ran into an issue where I was using a feature that was buggy until Rust 1.95, but we claim to support 1.88 in our config file.
Furthermore -- Since Firefox is one of the largest consumers of this crate -- We should probably ensure that our MSRV is aligned with Firefox's -- Which is currently 1.90.