8000 MacOS follow up · Issue #23 · rust-minidump/minidump-writer · GitHub
[go: up one dir, main page]

Skip to content

MacOS follow up #23

Closed
Closed

Description

@Jake-Shadle

#21 adds MacOS support but while testing I noticed a few things that might be improved, though it's hard to say given the embarrassing state of Apple's documentation. Writing this down now so I don't forget later.

  • Minidump supports thread names, however the MacOS implementation doesn't write that data, because Breakpad doesn't. This might (again, terrible documentation) be impossible since the thread name is actually part of pthreads, but on the minidump-writer side we are working with mach ports which are (mostly?) paired with a pthread, but AFAICT the API to retrieve the thread name for the pthread is task specific and probably won't work? But this would be extremely nice information to have if we can get it reliably. There might be some shenanigans to be done by finding out where the BSD pthread info is located in the process space and just reading it directly from the process memory like we do with eg the thread stack etc.

Activity

  1. gabrielesvelto commented on May 24, 2022

    @gabrielesvelto
    Contributor

    We've already implemented this in Breakpad, see: https://hg.mozilla.org/mozilla-central/rev/63e43c6f4114

    Porting it should be straightforward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions

      0