Repository navigation
Add android testing CI job - #115
Merged
Merged
Conversation
afranchuk
force-pushed
the
android-testing
branch
2 times, most recently
from
April 10, 2024 20:07
2aad634 to
b13d145
Compare
Contributor
|
I'm going to defer this review to @Jake-Shadle as my knowledge of the GitHub CI machinery is very limited. |
afranchuk
force-pushed
the
android-testing
branch
4 times, most recently
from
April 10, 2024 20:28
9f44779 to
5f9da99
Compare
afranchuk
force-pushed
the
android-testing
branch
from
April 10, 2024 20:40
5f9da99 to
954fc67
Compare
Jake-Shadle
approved these changes
Apr 11, 2024
Collaborator
There was a problem hiding this comment.
LGTM, and doesn't seem to be wildly slower than the other jobs, good to finally have this tested, thanks! Is there the possibility of targeting aarch64 android as well? While testing that the syscalls on android work as expected, there is still a gap of any code that happens to be specific to both android + aarch64 that we could miss.
Collaborator
Author
|
@Jake-Shadle yes, I believe we can! I'll try that out as well. FWIW there's also a way to cache the android virtual device, I'll try that out to see how much faster it is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating a PR to run and develop the job.