Repository navigation
CI: ARM native tests and platform-specific Clippy - #197
Merged
Merged
Conversation
schopin-mozilla
requested review from
Jake-Shadle and
gabrielesvelto
as code owners
August 6, 2026 10:05
schopin-mozilla
force-pushed
the
arm-clippy
branch
from
August 6, 2026 10:09
52f842a to
e26ee8c
Compare
Collaborator
Author
|
The GH action doesn't appear to pull the appropriate target. Marking it as Draft while I'm investigating. |
schopin-mozilla
marked this pull request as draft
August 6, 2026 10:22
schopin-mozilla
force-pushed
the
arm-clippy
branch
4 times, most recently
from
August 6, 2026 15:30
a93a47f to
6fe61e5
Compare
We keep the main amd64 Linux clippy run for smoketesting, but we also need a platform-specific to cover all those codepaths that are arch/OS specific.
schopin-mozilla
force-pushed
the
arm-clippy
branch
2 times, most recently
from
August 6, 2026 15:40
efb6471 to
89868d9
Compare
There are now native ARM runners available, we might as well take advantage.
schopin-mozilla
force-pushed
the
arm-clippy
branch
from
August 6, 2026 15:41
89868d9 to
9b1ed22
Compare
Clippy error:
error: this `if` statement can be collapsed
--> src/linux/dumper_cpu_info/arm.rs:276:9
|
276 | / if field == "Features" {
277 | | if let Some(val) = value {
278 | | elf_hwcaps = parse_features(val);
279 | | }
280 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#collapsible_if
We do it the proper way on Mac, checking that the child was indeed
killed by us. Sadly, the Windows APIs available don't allow us to
do the same there.
Example clippy complaint:
error: spawned process is never `wait()`ed on
--> tests\windows_minidump_writer.rs:135:21
|
135 | let mut child = start_child_and_return(&[&format!("{:x}", EXCEPTION_ILLEGAL_INSTRUCTION)]);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: consider calling `.wait()`
= note: not doing so might leave behind zombie processes
Clippy warning:
error: manually constructing a nul-terminated string
--> src/mac/streams/module_list.rs:375:21
|
375 | b"__TEXT\0".as_ptr(),
| ^^^^^^^^^^^ help: use a `c""` literal: `c"__TEXT"`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.97.0/index.html#manual_c_str_literals
schopin-mozilla
force-pushed
the
arm-clippy
branch
from
August 7, 2026 10:32
9b1ed22 to
0fc061a
Compare
schopin-mozilla
marked this pull request as ready for review
August 7, 2026 12:01
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds Linux arm64 in the set of main targets (GH has had runners for a while now), and runs clippy for all those main targets rather than just for x86_64-unknown-linux-gnu, since we have a sizable amount of platform-specific code that deserves to be checked.
And of course, bundled in are the various clippy fixes for the new failures those changes brought forward.