Repository navigation
Isolated Processes 10: Refactor ProcessReader - #198
Merged
Merged
Conversation
The way ProcessReader was implemented (creating a new one when a test requests it) was never a great approach, but it gets even worse when we can't allocate memory in the executor process. This refactors it to simply hold one ProcessReader at a time, which can be changed by a client that has an exclusive reference to the backend.
Jake-Shadle
removed their request for review
August 12, 2026 08:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The way ProcessReader was implemented (creating a new one when a test requests it) was never a great approach, but it gets even worse when we can't allocate memory in the executor process.
This refactors it to simply hold one ProcessReader at a time, which can be changed by a client that has an exclusive reference to the backend.