Repository navigation
Isolated Processes 11: Use a user-chosen handler for drop failures - #199
Merged
Merged
Conversation
Logging drop failures is generally a good idea... Except that logging in the executor could be a disaster if a logger has already been installed that tries to print to STDERR. This allows the user to install their own optional Drop failure handler. In an executor process, this simply wouldn't ever be used, so the executor will always do nothing when a Drop fails. Unfortunate, but not much else we can do.
Jake-Shadle
removed their request for review
August 12, 2026 08:21
gabrielesvelto
approved these changes
Aug 12, 2026
Base automatically changed from
isolated_process/10-refactor-process-reader
to
main
August 12, 2026 15:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logging drop failures is generally a good idea... Except that logging in the executor could be a disaster if a logger has already been installed that tries to print to STDERR.
This allows the user to install their own optional Drop failure handler. In an executor process, this simply wouldn't ever be used, so the executor will always do nothing when a Drop fails. Unfortunate, but not much else we can do.