Repository navigation
tests: get a test on module list properties - #208
Merged
Merged
Conversation
We're about to do some extensive work on the module list, and the existing integration tests only cover the "which modules do we have" part. Let's add a new test that encodes some other properties of the list: it starts with the executable, and the modules don't overlap. This should make working on that specific feature feel a bit more confident.
schopin-mozilla
requested review from
Jake-Shadle and
gabrielesvelto
as code owners
August 17, 2026 11:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're about to do some extensive work on the module list, and the existing integration tests only cover the "which modules do we have" part.
Let's add a new test that encodes some other properties of the list: it starts with the executable, and the modules don't overlap. This should make working on that specific feature feel a bit more confident.
Split off the #195 work.