8000 Isolated Processes 13: Change ProcessInspector into a dyn trait by marti4d · Pull Request #201 · rust-minidump/minidump-writer · GitHub
[go: up one dir, main page]
Skip to content

Isolated Processes 13: Change ProcessInspector into a dyn trait - #201

Merged
marti4d merged 1 commit into
mainfrom
isolated_process/13-process-inspector-trait
Aug 20, 2026
Merged

Isolated Processes 13: Change ProcessInspector into a dyn trait#201
marti4d merged 1 commit into
mainfrom
isolated_process/13-process-inspector-trait

Conversation

@marti4d
@marti4d marti4d commented Aug 10, 2026
Copy link
Copy Markdown
Collaborator

No description provided.

@marti4d
marti4d force-pushed the isolated_process/12-result-and-visibility branch from c853048 to 4204f72 Compare August 11, 2026 17:19
@marti4d
marti4d force-pushed the isolated_process/13-process-inspector-trait branch from 5dce91b to 76173b0 Compare August 11, 2026 17:28
@Jake-Shadle
Jake-Shadle removed their request for review August 12, 2026 08:22
@marti4d
marti4d commented Aug 12, 2026 •
edited
Loading
Copy link
Copy Markdown
Collaborator Author

@gabrielesvelto - This change may look big, but everything worth looking at happens in process_inspection/mod.rs and (to a lesser extent) process_inspection/process_reader.rs. Everything else is basically just me adding the word dyn to something or adding .as_ref() to something because Box<dyn Trait> doesn't automatically coerce to &dyn Trait.

@marti4d
marti4d force-pushed the isolated_process/12-result-and-visibility branch from 4204f72 to b57e996 Compare August 17, 2026 15:15
@marti4d
marti4d force-pushed the isolated_process/13-process-inspector-trait branch from 76173b0 to 9f861d5 Compare August 17, 2026 15:15
Base automatically changed from isolated_process/12-result-and-visibility to main August 17, 2026 18:52
gabrielesvelto
gabrielesvelto approved these changes 8000 Aug 19, 2026
View reviewed changes
@gabrielesvelto gabrielesvelto left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this just needs rebasing

@marti4d
marti4d force-pushed the isolated_process/13-process-inspector-trait branch from 9f861d5 to 3659c4b Compare August 20, 2026 13:40
@marti4d
marti4d merged commit d1dd45c into main Aug 20, 2026
16 checks passed
@marti4d
marti4d deleted the isolated_process/13-process-inspector-trait branch August 20, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielesvelto gabrielesvelto gabrielesvelto approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marti4d @gabrielesvelto
0