8000 Isolated Processes 14: Add traits for process-backend implementations by marti4d · Pull Request #202 · rust-minidump/minidump-writer · GitHub
[go: up one dir, main page]

Skip to content

Isolated Processes 14: Add traits for process-backend implementations - #202

Merged
marti4d merged 1 commit into
mainfrom
isolated_process/14-process-backend-traits
Aug 21, 2026
Merged

marti4d merged 1 commit into
mainfrom
isolated_process/14-process-backend-traits

Conversation

@marti4d
@marti4d marti4d commented Aug 10, 2026
Copy link
Copy Markdown
Collaborator

We are about to have a second set of implementations for the various process-backend types (the remote kind).

We can, of course, implement the ProcessInspector traits for each of these, individually, but I think it makes good sense from an API perspective for process-backend to establish "this is my contract" rather than having two separate contracts for local and remote implementations.

Of course, the nice part is that now ProcessInspector can be blanket implementated for all Backend types at once.

@marti4d
marti4d force-pushed the isolated_process/13-process-inspector-trait branch from 5dce91b to 76173b0 Compare August 11, 2026 17:28
@marti4d
marti4d force-pushed the isolated_process/14-process-backend-traits branch from 2f0b9f3 to 06e3ae5 Compare August 11, 2026 17:29
@Jake-Shadle
Jake-Shadle removed their request for review August 12, 2026 08:22
@marti4d
marti4d force-pushed the isolated_process/13-process-inspector-trait branch from 76173b0 to 9f861d5 Compare August 17, 2026 15:15
@marti4d
marti4d force-pushed the isolated_process/14-process-backend-traits branch from 06e3ae5 to 3358ffc Compare August 17, 2026 15:15
@marti4d
marti4d force-pushed the isolated_process/13-process-inspector-trait branch from 9f861d5 to 3659c4b Compare August 20, 2026 13:40
Base automatically changed from isolated_process/13-process-inspector-trait to main August 20, 2026 13:47
@marti4d
marti4d force-pushed the isolated_process/14-process-backend-traits branch from 3358ffc to f5a3d4b Compare August 20, 2026 14:37
We are about to have a second set of implementations for the various
process-backend types (the remote kind).

We can, of course, implement the `ProcessInspector` traits for each of these,
individually, but I think it makes good sense from an API perspective for
process-backend to establish "this is my contract" rather than having two
separate contracts for `local` and `remote` implementations.

Of course, the nice part is that now `ProcessInspector` can be blanket
implementated for all `Backend` types at once.
@marti4d
marti4d force-pushed the isolated_process/14-process-backend-traits branch from f5a3d4b to efd58e0 Compare August 20, 2026 19:30
@gabrielesvelto gabrielesvelto left a comment
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marti4d
marti4d merged commit 7d90641 into main Aug 21, 2026
16 checks passed
@marti4d
marti4d deleted the isolated_process/14-process-backend-traits branch August 21, 2026 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0