Repository navigation
linux: modules: clamp when they overlap other modules - #215
Merged
Merged
Conversation
schopin-mozilla
force-pushed
the
module-clamp
branch
from
August 21, 2026 20:42
e19384e to
2e88680
Compare
Collaborator
Author
|
Hmm, I tried to do the Stack PR thing but it failed, apparently it needs to be enabled at the repo level. Oh well. In this case, DO NOT MERGE before #212 ! |
schopin-mozilla
force-pushed
the
module-clamp
branch
from
August 26, 2026 14:08
2e88680 to
e2b0d3d
Compare
gabrielesvelto
approved these changes
Aug 31, 2026
Contributor
There was a problem hiding this comment.
LGTM for the last patch (given the rest will land in the previous PR)
This isn't a problem yet (barring user-provided data, of course) since the procmaps approach cannot, by obstruction, generate overlapping modules, but it will become a problem when we'll be using the DT_DEBUG data. Indeed, some objects are disjointed in memory, and because of that you can have other modules inserted into the gap. In particular, on Linux arm64, the vDSO routinely lands in the middle of ld.so segments. It's usually benign since the latter segments are only data, not code, and we record an error if not.
schopin-mozilla
force-pushed
the
module-clamp
branch
from
August 31, 2026 16:47
e2b0d3d to
dee6396
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This isn't a problem yet (barring user-provided data, of course) since
the procmaps approach cannot, by obstruction, generate overlapping
modules, but it will become a problem when we'll be using the DT_DEBUG
data.
Indeed, some objects are disjointed in memory, and because of that you
can have other modules inserted into the gap. In particular, on Linux
arm64, the vDSO routinely lands in the middle of ld.so segments.
It's usually benign since the latter segments are only data, not code,
and we record an error if not.