Repository navigation
linux: change some APIs to use mem address rather than mapping index - #210
Merged
Merged
Conversation
schopin-mozilla
requested review from
Jake-Shadle and
gabrielesvelto
as code owners
August 17, 2026 18:24
Those APIs are used to get data that's typically module-related, so having them take in an index into the *mappings* list can get pretty awkward once we start separating those concerns. As a bonus, I find the client code to be more readable, although YMMV.
schopin-mozilla
force-pushed
the
apis-index
branch
from
August 17, 2026 18:31
01e77e4 to
a0c695d
Compare
marti4d
approved these changes
Aug 17, 2026
Collaborator
There was a problem hiding this comment.
Lol thanks for doing this -- Yep, I agree. The old API was awkward, and this is much better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those APIs are used to get data that's typically module-related, so having them take in an index into the mappings list can get pretty awkward once we start separating those concerns.
As a bonus, I find the client code to be more readable, although YMMV.
Split off #195 (I'm running out of small pieces I can spin out independently, sadly)