8000 Fix clippy lint broken with new Rust release by marti4d · Pull Request #213 · rust-minidump/minidump-writer · GitHub
[go: up one dir, main page]

Skip to content
8000

Fix clippy lint broken with new Rust release - #213

Merged
marti4d merged 1 commit into
mainfrom
clippy
Aug 20, 2026
Merged

marti4d merged 1 commit into
mainfrom
clippy

Conversation

@marti4d
@marti4d marti4d commented Aug 20, 2026
Copy link
Copy Markdown
Collaborator

No description provided.

@marti4d
marti4d commented Aug 20, 2026
Copy link
Copy Markdown
Collaborator Author

@gabrielesvelto This doesn't actually need a code review (trivial change), but it's worth thinking about if we want to always continue the current behavior of having our CI automatically jump up to the latest version of Rust.

The combination of "CI automatically updates Rust" + "We run clippy and fail on any warning" means that code that was passing tests one day can fail them the next day without anybody explicitly doing anything. Not great...

@marti4d
marti4d merged commit 78789df into main Aug 20, 2026
16 checks passed
@marti4d
marti4d deleted the clippy branch August 20, 2026 19:21
@gabrielesvelto
Copy link
Copy Markdown
Contributor

The combination of "CI automatically updates Rust" + "We run clippy and fail on any warning" means that code that was passing tests one day can fail them the next day without anybody explicitly doing anything. Not great...

Good point. I'll open an issue, updating the harness to pick a new version of Rust only after we've verified that it works is a better path forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

0